NightWind's Card Searcher

If I remember correctly, it worked as far as showing the prices and such, but if a card didn't have a seller in that range, it would still show but it would say there were no sellers.

And the bug of crashing when unknown conditions were met...

Yeah - the price range search is still on the dev site. I'm not going to work on it anymore due the limitations of the database. After finding the cards within the price range, it does an "OR" operation on the database and this kills it. The database can't handle so many ORs. If your range is small enough then it will go through, if not, then you can try reducing the range. This is about all I can do for now. Maybe I might try a Javascript version, but that would be overkill at this stage. So yeah, as much as this is a good idea, it can't happen just yet. Don't keep your hopes up waiting for this - I'm not going to do it unless I'm surprisingly bored and there is nothing on TV...

However, I am still open to suggestions and bugfixes.

...Cancel the OR operation?

(02-08-2009 06:21 AM)Runemaster Wrote:  ...Cancel the OR operation?

Canceling the OR would lead results which look like you've been snowed in, so that returns us to the current situation.

By performing an OR on only a subset, that would actually lead to incomplete results - which would be quite bad for this situation as it becomes misleading in a search for say, all voucher cards under 2000.

I might try splitting and joining, but can't be bothered for now as I have too much stuff on my hands.

Could you do it so that you can't search specifics, only the price range?

What's the point of a minimum price? I could see why you'd want to know all cards meeting criteria X and costing under 5000 points (you only have 5000 points), but why only cards costing over 1000 points?

(02-09-2009 05:49 AM)Runemaster Wrote:  Could you do it so that you can't search specifics, only the price range?

That wouldn't improve the situation much. What happens is that it parses the store feed, finds the cards within range and then ORs the cards (hehe, I made a new word). That ORing kills the query. Which is why the search only works for price ranges which return a small number of cards.

(02-09-2009 05:50 AM)masamunemaniac Wrote:  What's the point of a minimum price? I could see why you'd want to know all cards meeting criteria X and costing under 5000 points (you only have 5000 points), but why only cards costing over 1000 points?

*light shrug*

It was supposed to reduce the result set to a more suitable quantity, but even with the minimum price, the cards to be ORed are too many for the query to handle.

Option 1:
I suppose the only solution I have left for now is to split then recombine the queries. Judging by the interest for this feature expressed here, I might as well give it a go this weekend.

Option 2:
On second thought, I could always just get the price range, return the card ids only and then use getcard? That... could very well work. It may mean writing another program module, but that sure beats fiddling with SQL technical restrictions. But do note that this method will not integrate with the other search functions. Thus, you cannot search for all cards cheaper than 2000, and is in the MC expansion.

Feh. From the looks of it, option 2 will eventually point back to option 1... I'll try option 1 this weekend, and resort to option 2 if needed. Thoughts?

I love you.

I just thought of something. Concerning the minimum price feature, while I don't know if it's codeable (and if it is, I'm sure it might be difficult).

But the idea is, let's say you search 1000-5000 and mana bucket comes up (most likely either because somebody did the overpriced bucket trick or because it's overpriced just to keep the store open if everything else sells out). Obviously, there's going to be cheaper ones, so would it be possible to list the cheaper prices or maybe have a note say that there are cheaper prices for this card?

In reverse, perhaps the same for the maximum price, but obviously have it mention there are more expensive prices for this card.

I think that was how it worked on the test site (could be wrong though).

I still don't get why you'd want a minimum price though. I mean, why would you be more interested in Pirate Captain if there was one available for 1000 points but not interested if the most expensive one was 900 points?

well i don't know about others but i'd like a minimum price so i could check cards from say....remembrance to Y1C price ranges if i have a ton of points i want to spend but don't know exactly what i want to buy yet

(02-09-2009 08:22 AM)Runemaster Wrote:  I love you.

Daww... you're so sweet! ^.^ *now feels warm and fuzzy*

(02-09-2009 11:25 AM)Jessica Stryker Wrote:  I just thought of something. Concerning the minimum price feature, while I don't know if it's codeable (and if it is, I'm sure it might be difficult).

But the idea is, let's say you search 1000-5000 and mana bucket comes up (most likely either because somebody did the overpriced bucket trick or because it's overpriced just to keep the store open if everything else sells out). Obviously, there's going to be cheaper ones, so would it be possible to list the cheaper prices or maybe have a note say that there are cheaper prices for this card?

In reverse, perhaps the same for the maximum price, but obviously have it mention there are more expensive prices for this card.

I'm guessing you mean comparing multiple versions of mana bucket as the results are now already sorted. I haven't though about comparing different versions of cards yet as I'm going to work on getting the price range working first before thinking features which add onto that. If I do happen to get the price range to work fully, but forget about the points you mentioned here, remind me.

(02-09-2009 11:45 AM)masamunemaniac Wrote:  I think that was how it worked on the test site (could be wrong though).

The site orders the cards by id. It's been while since I touched the code. I'll try to get the price range basics done first then work whatever needs working on.

(02-09-2009 11:45 AM)masamunemaniac Wrote:  I still don't get why you'd want a minimum price though. I mean, why would you be more interested in Pirate Captain if there was one available for 1000 points but not interested if the most expensive one was 900 points?

The minimum for the price range was an attempt to reduce the result set down to a number accepted by the query, but as you can see, that method doesn't work that well.

(02-09-2009 01:53 PM)NOLDER Wrote:  well i don't know about others but i'd like a minimum price so i could check cards from say....remembrance to Y1C price ranges if i have a ton of points i want to spend but don't know exactly what i want to buy yet

Oh and that too. Good point. Ah, here's to a tired NightWind.

---

I just though of something. I may be able to run the SQL query that's generated from the rest of the search form. Then, I can filter the results according to the card ids found in the price range search. That way, I can have the best of both worlds without it becoming too complex or time consuming. That could work - I'll try this first.

This version here now should contain a fully working price search. No more crashing due to SQL, no more range limitations.

Those who read this: let me know if it works as you want it to and if you find any price range related bugs.

After I get the confirmation all is fine, I'll move it to the main site then look into Jessica's suggestion. But for now, I just want to know if the basics are what you want.

The HS results are somehow included with no regards as to whether the HS box is ticked. But I'll look into that another time. I probably just overwritten some previous code. Too tired now.

Edit: And just saw that the Masterwork Tools icon is missing. I think someone here has mentioned it, but I forgotten. It was only until I saw that particular Post-it buried under all the others on my wall that I remembered. Will fix soon.

edit2: Just noticed if MT is selected on a clear search, the formatting goes all weird.

*scribbles on a Post-it*

*sticks*

I did one search just to test it, and I think you already implemented my idea.

Did a search of 1000-3000.

Using blank clone as an example:

karl17 7 @ 780 ea
masamunemaniac 17 @ 900 ea
Tamdrik 29 @ 1000 ea
aperson 1 @ 1500 ea

So, from the first run through, it seems like it works already. Plus, the problem we had earlier (when non sellers or at least non sellers in that price range) isn't showing up, so yay.

i'm confused

i searched for all cards ranging from 5000 to 20000 points but i got clash summoner ardam (among some other weird results)

the price search doesn't eliminate cards that are being sold for cheaper then the minimum?
i see that the most expensive ardam is being sold for 6000 but there are i think over 60 other ardams selling for less then 500 points each (depending on who you buy from)

That's how Jessica Stryker wants it to work... and besides, you wouldn't want to be told a card's available for 6k, but it for that, and then find out it's also available for 300 elsewhere would you?

i figured ardam would be eliminated from the search completely since it's minimum price falls below my search's minimum

i guess it works this way too but it'll give a lot of...unintended results

Only because people apply stupid prices to their cards

HS results aren't shown unless you also ask for store prices.